Skip to content

[HTTP] Copy array returned by getRoutes#195647

Merged
jloleysens merged 2 commits intoelastic:mainfrom
jloleysens:http/get-routes-spread
Oct 10, 2024
Merged

[HTTP] Copy array returned by getRoutes#195647
jloleysens merged 2 commits intoelastic:mainfrom
jloleysens:http/get-routes-spread

Conversation

@jloleysens
Copy link
Copy Markdown
Contributor

@jloleysens jloleysens commented Oct 9, 2024 •
edited by kibanamachine
Loading

Summary

Small follow up based on #192675 (comment)

@jloleysens jloleysens added Feature:http Team:Core Platform Core services: plugins, logging, config, saved objects, http, ES client, i18n, etc t// release_note:skip Skip the PR/issue when compiling release notes v9.0.0 v8.16.0 backport:version Backport to applied version labels labels Oct 9, 2024
@jloleysens jloleysens requested a review from a team as a code owner October 9, 2024 16:40
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Oct 9, 2024

Pinging @elastic/kibana-core (Team:Core)

@jloleysens jloleysens enabled auto-merge (squash) October 9, 2024 16:55
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Oct 9, 2024 •
edited
Loading

💔 Build Failed

Failed CI Steps

Metrics [docs]

✅ unchanged

History

TinaHeiligers
TinaHeiligers approved these changes Oct 9, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@TinaHeiligers TinaHeiligers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jloleysens jloleysens merged commit a481da6 into elastic:main Oct 10, 2024
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Oct 10, 2024

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11270711052

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 10, 2024
@jloleysens
[HTTP] Copy array returned by getRoutes (elastic#195647)
1d70414 
## Summary

Small follow up based on
elastic#192675 (comment)

(cherry picked from commit a481da6)
@kibanamachine kibanamachine mentioned this pull request Oct 10, 2024
Merged
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Oct 10, 2024

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 10, 2024
@kibanamachine @jloleysens
[8.x] [HTTP] Copy array returned by `getRoutes` (#195647) (#…
8bd34c4 
…195714)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[HTTP] Copy array returned by `getRoutes`
(#195647)](#195647)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Jean-Louis
Leysens","email":"jeanlouis.leysens@elastic.co"},"sourceCommit":{"committedDate":"2024-10-10T08:53:59Z","message":"[HTTP]
Copy array returned by `getRoutes` (#195647)\n\n## Summary\r\n\r\nSmall
follow up based
on\r\nhttps://github.com//pull/192675#discussion_r1793601519","sha":"a481da68e58cb20d6407c9866c1511717addfdb0","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:http","Team:Core","release_note:skip","v9.0.0","v8.16.0","backport:version"],"title":"[HTTP]
Copy array returned by
`getRoutes`","number":195647,"url":"https://github.com/elastic/kibana/pull/195647","mergeCommit":{"message":"[HTTP]
Copy array returned by `getRoutes` (#195647)\n\n## Summary\r\n\r\nSmall
follow up based
on\r\nhttps://github.com//pull/192675#discussion_r1793601519","sha":"a481da68e58cb20d6407c9866c1511717addfdb0"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195647","number":195647,"mergeCommit":{"message":"[HTTP]
Copy array returned by `getRoutes` (#195647)\n\n## Summary\r\n\r\nSmall
follow up based
on\r\nhttps://github.com//pull/192675#discussion_r1793601519","sha":"a481da68e58cb20d6407c9866c1511717addfdb0"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Jean-Louis Leysens <jeanlouis.leysens@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TinaHeiligers TinaHeiligers TinaHeiligers approved these changes

Assignees

No one assigned

Labels

backport:version Backport to applied version labels Feature:http release_note:skip Skip the PR/issue when compiling release notes Team:Core Platform Core services: plugins, logging, config, saved objects, http, ES client, i18n, etc t// v8.16.0 v9.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jloleysens @elasticmachine @kibanamachine @TinaHeiligers